Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saskia Bollmann adds image to venue page. #164

Merged
merged 5 commits into from
Jun 11, 2020

Conversation

SaskiaBollmann
Copy link
Contributor

Dear Remi,

I have added a picture of Steffen and me to the repo for the venue webpage as a test/example for the github traintrack. Would be great if you could merge it and also take a few screenshots along the way :)))) Just to show how it looks like on your end ;)

All the best,
Saskia

@welcome
Copy link

welcome bot commented Jun 11, 2020

Thank You Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808)
💖 Thanks for opening this pull request! 💖 We really appreciate your time and effort to contribute to the project. If you are trying to add your contribution to our Venue page, please make sure you have read our instructions and have shared all relevant details in your pull request. The OHBM Brainhack webteam might be a bit busy right now but we will have a look at your suggestion very quickly.

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey the first line you added needs a -

@Remi-Gau
Copy link
Contributor

thanks for this!! 🙏

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you would also need to add a copy of the image in the img/venue folder. You already have an image in the team folder but the Jekyll script on our side is set up to look for images the venue one.

@Remi-Gau
Copy link
Contributor

OK I will change the instructions in the issue. :-)

@Remi-Gau
Copy link
Contributor

OK I will change the instructions in the issue. :-)

issue #64 updated

@Remi-Gau
Copy link
Contributor

It all looks good on my side. :-)

@SaskiaBollmann
Copy link
Contributor Author

Image and '-' should be there now - luckily I'm trying this out before giving the lecture 😉 Will definitively have everyone give a go - I think it's a great example!

@Remi-Gau
Copy link
Contributor

Will merge. See the Bot in action. 😄 🤖 ❤️

@Remi-Gau Remi-Gau merged commit 473a14a into ohbm:master Jun 11, 2020
@welcome
Copy link

welcome bot commented Jun 11, 2020

Congratulations Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808)
Congrats on merging your first pull request! 🎉 We here at OHBM Brainhack team really appreciate your contribution! 💖 Go ahead and share your your first merge with your colleagues, you got yourself this brag right! 😄 🎁

@SaskiaBollmann
Copy link
Contributor Author

Wow, this is pretty fancy 🥇 But it cuts off our face on the webpage 😢
image
Maybe you want to add some comments on the preferred dimensions of the image?

@Remi-Gau
Copy link
Contributor

Screenshot 2020-06-11 08:37:27

Oops...

This seems to be a responsive web-design issue. When I resize my browser window I can see the whole thing. I will call in the web-design wizards to help me with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants