Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding image to venue page #242

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Conversation

martsc1
Copy link
Contributor

@martsc1 martsc1 commented Jun 16, 2020

Hi all,

I'm testing the pull request exercise.

Cheers,
Martin

@welcome
Copy link

welcome bot commented Jun 16, 2020

Thank You Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808)
💖 Thanks for opening this pull request! 💖 We really appreciate your time and effort to contribute to the project. If you are trying to add your contribution to our Venue page, please make sure you have read our instructions and have shared all relevant details in your pull request. The OHBM Brainhack webteam might be a bit busy right now but we will have a look at your suggestion very quickly.

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will need to update the _data/venue.ymlfile to add your file name into it

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the point 6 of the issue.

Modify the _data/venue.yml
You can simply add the following code to the top of the file and replace the YOUR NAME and IMAGE_FILENAME with the appropriate values.

Let me know if I can help.

@martsc1
Copy link
Contributor Author

martsc1 commented Jun 16, 2020

Did it work now?

@Remi-Gau
Copy link
Contributor

Yup !!!

I will merge you pull request.

Congratulation !!!

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Remi-Gau Remi-Gau merged commit 0abdea0 into ohbm:master Jun 16, 2020
@welcome
Copy link

welcome bot commented Jun 16, 2020

Congratulations Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808)
Congrats on merging your first pull request! 🎉 We here at OHBM Brainhack team really appreciate your contribution! 💖 Go ahead and share your your first merge with your colleagues, you got yourself this brag right! 😄 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants