Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add “modified_date” & “updated_by” to the User table #2085

Closed
sainak opened this issue Apr 15, 2024 · 4 comments · May be fixed by #2632
Closed

Add “modified_date” & “updated_by” to the User table #2085

sainak opened this issue Apr 15, 2024 · 4 comments · May be fixed by #2632
Assignees
@JohnLu2004

Comments

@sainak
Copy link
Member

sainak commented Apr 15, 2024 •
edited
Loading

Add “modified_date” & “updated_by” to the User table for tracking updates made by admins

cc @gigincg
@sainak sainak changed the title Add “updated_at” & “updated_by” to the User table Add “modified_date” & “updated_by” to the User table Apr 15, 2024
@ayushchauhan12
Copy link
Contributor

@sainak I would like to work on this issue

ayushchauhan12 added a commit to ayushchauhan12/care that referenced this issue Apr 21, 2024
@ayushchauhan12
Add “modified_date” & “updated_by” to the User table ohcnetwork#2085
c59c884
@ayushchauhan12 ayushchauhan12 mentioned this issue Apr 21, 2024
Closed
4 tasks
@ayushchauhan12 ayushchauhan12 removed their assignment Apr 27, 2024
@dhruv-goyal-10
Copy link
Contributor

@sainak What behaviour do we want to implement on User object creation?

Initially SET updated_by to null
or
Initially SET updated_by equal to created_by

@JohnLu2004
Copy link
Contributor

@sainak Could I be assigned this issue?

@github-project-automation github-project-automation bot moved this to Triage in Care Nov 30, 2024
@rithviknishad rithviknishad moved this from Triage to Up Next in Care Nov 30, 2024
@JohnLu2004
Copy link
Contributor

JohnLu2004 commented Dec 1, 2024 •
edited
Loading

I've been looking through these files...

@sainak and @rithviknishad , my general approach is to add the 2 fields in both files. Then make the migrations and the migrations file, so that application logic and ORM are in sync with db. Also, should updating these fields every time someone modifies a user be in the PR as well? Right now, it seems we're just adding in 2 fields. Let me know your thoughts :)

JohnLu2004 pushed a commit to JohnLu2004/care that referenced this issue Dec 3, 2024
Added a modified_date
a331bec 
Fixes ohcnetwork#2085
Took inspiration from field ``doctor_experience_commenced_on`` on how to create a new field in the codespace
Used ``python manage.py makemigrations`` and ''python manage.py migrate'' to create new field in the database table
@JohnLu2004 JohnLu2004 mentioned this issue Dec 3, 2024
Draft
4 tasks
JohnLu2004 pushed a commit to JohnLu2004/care that referenced this issue Dec 3, 2024
Added a modified_date and updated_by field
1d245cc 
Fixes ohcnetwork#2085
Took inspiration from field ``doctor_experience_commenced_on`` on how to create new fields in the codespace
Used ``python manage.py makemigrations`` and ''python manage.py migrate'' to create new fields in the database table
@vigneshhari vigneshhari closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2025
@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnLu2004 JohnLu2004

Labels
None yet
Projects
Care
Status: Done
Milestone
No milestone
5 participants
@vigneshhari @sainak @ayushchauhan12 @JohnLu2004 @dhruv-goyal-10