Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to libphonenumber-js in favour of custom phone number validators #9966

Closed
3 tasks
rithviknishad opened this issue Jan 14, 2025 · 11 comments
Closed
3 tasks
Assignees
Labels
P1 breaking issue or vital feature

Comments

@rithviknishad
Copy link
Member

rithviknishad commented Jan 14, 2025

Action Items

@rithviknishad rithviknishad added the good first issue Good for newcomers label Jan 14, 2025
@manmeetnagii
Copy link
Contributor

Can I work on this issue?

@rithviknishad
Copy link
Member Author

@manmeetnagii most of heavy lifting was done in https://github.com/ohcnetwork/care_fe/tree/rithviknishad/feat/switch-to-libphonenumberjs branch. You may use this as your base branch

@manmeetnagii
Copy link
Contributor

@manmeetnagii most of heavy lifting was done in https://github.com/ohcnetwork/care_fe/tree/rithviknishad/feat/switch-to-libphonenumberjs branch. You may use this as your base branch

okay

@rithviknishad
Copy link
Member Author

Error handling in certain situations was pending, and also updating existing other usages where input type="tel" directly was used instead of PhoneInput

@manmeetnagii
Copy link
Contributor

Error handling in certain situations was pending, and also updating existing other usages where input type="tel" directly was used instead of PhoneInput

can I create a draft PR for review purposes?

@rithviknishad
Copy link
Member Author

sure!

@BigJoe17
Copy link

Action Items

@BigJoe17
Copy link

I would love to work on this issue

@kevalkanp1011
Copy link

I would like to work on this issue

@coderabbitai coderabbitai bot mentioned this issue Jan 27, 2025
6 tasks
@rithviknishad rithviknishad added P1 breaking issue or vital feature and removed good first issue Good for newcomers question Further information is requested work-in-progress needs-triage labels Jan 27, 2025
Copy link

⚠️ Refrain from assigning this issue to yourself if you have another P1 issue assigned that is not yet closed.
@rithviknishad kindly acknowledge this message by commenting 'Acknowledged' below.

@rithviknishad
Copy link
Member Author

@manmeetnagii Taking over as related issue #10164 is a priority.

@rithviknishad rithviknishad closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature
Projects
None yet
4 participants