-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to libphonenumber-js
in favour of custom phone number validators
#9966
Comments
Can I work on this issue? |
@manmeetnagii most of heavy lifting was done in https://github.com/ohcnetwork/care_fe/tree/rithviknishad/feat/switch-to-libphonenumberjs branch. You may use this as your base branch |
okay |
Error handling in certain situations was pending, and also updating existing other usages where input type="tel" directly was used instead of PhoneInput |
can I create a draft PR for review purposes? |
sure! |
|
I would love to work on this issue |
I would like to work on this issue |
|
@manmeetnagii Taking over as related issue #10164 is a priority. |
Action Items
PhoneNumberFormField
and replace them with shadcn'sinput
withtype="tel"
instead or feel free to explore other alternatives that reuses shadcn's components (such as https://shadcn-phone-input-five.vercel.app)libphonenumber-js
package.The text was updated successfully, but these errors were encountered: