Remove hardcoded date placeholder in ThreadItem component #10383

rithviknishad · 2025-02-04T06:36:18Z

Remove hardcoded date placeholder in ThreadItem component

Summary by CodeRabbit

Bug Fixes
- Updated discussion notes to display the actual thread creation date dynamically instead of a fixed placeholder date for improved accuracy.
New Features
- Enhanced message display by adding formatted creation and modification dates next to usernames.
- Improved error handling for message creation, potentially changing how errors are communicated to users.

coderabbitai · 2025-02-04T06:36:30Z

Walkthrough

The changes modify the EncounterNotesTab.tsx file by removing a hardcoded date in the ThreadItem component and replacing it with a dynamic date representation using the formatRelative function. Additionally, the Message interface in src/types/notes/messages.ts has been updated to include new properties for creation and modification dates, enhancing the structure of the message data. Error handling for message creation has also been altered.

Changes

File	Change Summary
`src/pages/Encounters/tabs/EncounterNotesTab.tsx`	Removed hardcoded date (`12/12/2024`) from `ThreadItem`; added dynamic date using `formatRelative` for `message.created_date`. Updated username display to include formatted date. Modified error handling for message creation.
`src/types/notes/messages.ts`	Updated `Message` interface: added `created_date: string` and `modified_date: string`; modified comment for `message` property to indicate Markdown content.

Possibly related PRs

Patient encounter notes #9617: The changes in the main PR are related to the modifications in the Message interface in the retrieved PR, as both involve updates to message handling and structure in the same file.
Fix: Display Modify date and i18n Localization in Patient Encounter Page #9696: The changes in the main PR are related to the modifications of date properties in the Message interface, which aligns with the updates to the modified_date property in the Encounter interface from the retrieved PR.

Suggested labels

changes required, needs review

Suggested reviewers

khavinshankar
Jacobjeevan

Poem

Hopping through lines of code I wander,
Static dates gone—no more ponder.
Dynamic threads now tell their tale,
With every message.created detail.
I'm a coding rabbit—joyful and fonder! 🐇✨

Tip

🌐 Web search-backed reviews and chat

We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
You can disable this feature by setting web_search: false in the knowledge_base settings.
Please share any feedback in the Discord discussion.

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-04T06:36:51Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`3bc0de5`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67a1bb47fc54560008165f3e
😎 Deploy Preview	https://deploy-preview-10383--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress · 2025-02-04T06:44:12Z

CARE Run #4595

Run Properties: Passed #4595 • 3bc0de5bb0: Remove hardcoded date placeholder in ThreadItem component

Project	`CARE`
Branch Review	`rithviknishad/fix/remove-hardcoded-date-encounter-notes`
Run status	`Passed #4595`
Run duration	`05m 56s`
Commit	`3bc0de5bb0: Remove hardcoded date placeholder in ThreadItem component`
Committer	`Rithvik Nishad`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`10`
View all changes introduced in this branch ↗︎

cloudflare-workers-and-pages · 2025-02-04T07:01:27Z

Deploying care-fe with Cloudflare Pages

Latest commit:	`3bc0de5`
Status:	✅ Deploy successful!
Preview URL:	https://368e5227.care-fe.pages.dev
Branch Preview URL:	https://rithviknishad-fix-remove-har.care-fe.pages.dev

View logs

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/types/notes/messages.ts (2)
5-5: Consider using JSDoc style comment for better documentation.

While the inline comment is helpful, using JSDoc style documentation would provide better IDE support and maintain consistency with TypeScript best practices.
-  message: string; // Markdown
+  /** Content in Markdown format */
+  message: string;
9-10: Consider using Date type for better type safety.

Since these properties are used with date-fns' formatRelative function, using the Date type would provide better type safety and built-in date operations. If string type is required due to API constraints, consider documenting the expected date format.
-  created_date: string;
-  modified_date: string;
+  /** ISO 8601 date string or Date type for better type safety */
+  created_date: Date;
+  /** ISO 8601 date string or Date type for better type safety */
+  modified_date: Date;

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4aa656 and 3bc0de5.

📒 Files selected for processing (2)

src/pages/Encounters/tabs/EncounterNotesTab.tsx (3 hunks)
src/types/notes/messages.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/pages/Encounters/tabs/EncounterNotesTab.tsx

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: cypress-run (1)
GitHub Check: Cloudflare Pages: care-fe

nihal467 · 2025-02-04T07:36:32Z

LGTM

github-actions · 2025-02-04T07:39:33Z

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Remove hardcoded date placeholder in ThreadItem component

f4aa656

rithviknishad requested a review from a team as a code owner February 4, 2025 06:36

Enhance message display with relative time and improved styling

3bc0de5

coderabbitai bot reviewed Feb 4, 2025

View reviewed changes

nihal467 added needs review tested labels Feb 4, 2025

khavinshankar approved these changes Feb 4, 2025

View reviewed changes

khavinshankar merged commit f2db2ba into develop Feb 4, 2025
22 checks passed

khavinshankar deleted the rithviknishad/fix/remove-hardcoded-date-encounter-notes branch February 4, 2025 07:39

This was referenced Feb 4, 2025

Enhancements to Encounter Discussion/Notes | Fix Translation #10156

Open

Added a pluggable to show abha details #10417

Merged

rithviknishad self-assigned this Feb 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove hardcoded date placeholder in ThreadItem component #10383

Remove hardcoded date placeholder in ThreadItem component #10383

rithviknishad commented Feb 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 4, 2025 •

edited

Loading

cypress bot commented Feb 4, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 4, 2025 •

edited

Loading

coderabbitai bot left a comment

nihal467 commented Feb 4, 2025

github-actions bot commented Feb 4, 2025

Remove hardcoded date placeholder in ThreadItem component #10383

Remove hardcoded date placeholder in ThreadItem component #10383

Conversation

rithviknishad commented Feb 4, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Feb 4, 2025 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 4, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

cypress bot commented Feb 4, 2025 • edited Loading

CARE Run #4595

cloudflare-workers-and-pages bot commented Feb 4, 2025 • edited Loading

Deploying care-fe with Cloudflare Pages

coderabbitai bot left a comment

Choose a reason for hiding this comment

nihal467 commented Feb 4, 2025

github-actions bot commented Feb 4, 2025

rithviknishad commented Feb 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 4, 2025 •

edited

Loading

cypress bot commented Feb 4, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 4, 2025 •

edited

Loading