Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clipping issue login page #7891

Merged

Conversation

sunny-thakurwar
Copy link
Contributor

@sunny-thakurwar sunny-thakurwar commented May 24, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sunny-thakurwar sunny-thakurwar requested a review from a team as a code owner May 24, 2024 09:14
Copy link

vercel bot commented May 24, 2024

@sunny-thakurwar is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented May 24, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b1aecf6
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c818d62a8b9f000837cda1
😎 Deploy Preview https://deploy-preview-7891--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sunny-thakurwar sunny-thakurwar changed the title fix clipping issue login page Fix clipping issue login page May 24, 2024
@sunny-thakurwar
Copy link
Contributor Author

@nihal467 can you please check once

@nihal467
Copy link
Member

nihal467 commented May 28, 2024

@sunny-thakurwar
image

  • When we select the Tamil language, it uses three rows in the normal desktop view, even though there is enough space. Please make it responsive so that it only uses two rows. Kindly comment if there are any technical limitations.

@sunny-thakurwar
Copy link
Contributor Author

sunny-thakurwar commented May 29, 2024

@nihal467 the text looks fine on my system. committed some changes hope this resolves the issue. if the issue persists please share the screen resolution you are testing on which it is breaking. also share browser version.

image

@nihal467
Copy link
Member

nihal467 commented Jun 5, 2024

@sunny-thakurwar
image

when we click the Kannada language, even though we can write it in a single row, it utilising two rows, can you check it

@sunny-thakurwar
Copy link
Contributor Author

sunny-thakurwar commented Jun 5, 2024

@nihal467 @rithviknishad srry for the reworks. i fixed the issue mentioned in comment. can you please check now

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 14, 2024
Copy link

Hi, @coronasafe/care-frontend-maintainers, This PR has been automatically closed due to inactivity. Thank you for your contributions. Feel free to re-open the PR.

@gigincg gigincg merged commit e5ede19 into ohcnetwork:develop Aug 23, 2024
29 of 30 checks passed
Copy link

@sunny-thakurwar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

UdaySagar-Git pushed a commit to UdaySagar-Git/care_fe that referenced this pull request Aug 23, 2024
Co-authored-by: Gigin George <mail.gigin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login-in page is clipping in
4 participants