Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the add location button positioning in desktop view #8481

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Fixed the add location button positioning in desktop view #8481

merged 4 commits into from
Sep 5, 2024

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Sep 4, 2024

Proposed Changes

  • Fixes #issue_number
  • Change 1
  • Change 2
  • More?

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@nihal467 nihal467 requested a review from a team as a code owner September 4, 2024 13:44
@netlify Netlify
Copy link

netlify bot commented Sep 4, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ea5fc86
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66d9a1f00f95e600084aea60
😎 Deploy Preview https://deploy-preview-8481--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Sep 4, 2024 •
edited
Loading

CARE    Run #3278

Run Properties:  status check passed Passed #3278  •  git commit ea5fc86ccc: Fixed the add location button positioning in desktop view
Project CARE
Branch Review fix-positioning-addlocationbutton
Run status status check passed Passed #3278
Run duration 03m 07s
Commit git commit ea5fc86ccc: Fixed the add location button positioning in desktop view
Committer Mohammed Nihal
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 127
View all changes introduced in this branch ↗︎

@nihal467 nihal467 self-assigned this Sep 4, 2024
@nihal467
Copy link
Member Author

nihal467 commented Sep 5, 2024

LGTM

@khavinshankar khavinshankar merged commit e69116f into develop Sep 5, 2024
29 checks passed
@khavinshankar khavinshankar deleted the fix-positioning-addlocationbutton branch September 5, 2024 12:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

@nihal467 @nihal467 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees

@nihal467 nihal467

Labels
needs review tested
Projects
Care
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nihal467 @rithviknishad @khavinshankar