Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send only known BP attributes #8703

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Send only known BP attributes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner October 4, 2024 06:03
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit bfd5924
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66ff85463b232b00089d5de7
😎 Deploy Preview https://deploy-preview-8703--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: bfd5924
Status: ✅  Deploy successful!
Preview URL: https://9c6120a5.care-fe.pages.dev
Branch Preview URL: https://rithviknishad-fix-send-known.care-fe.pages.dev

View logs

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Oct 4, 2024
@rithviknishad rithviknishad self-assigned this Oct 4, 2024
Copy link

cypress bot commented Oct 4, 2024

CARE    Run #3529

Run Properties:  status check passed Passed #3529  •  git commit bfd5924a32: Send only known BP attributes
Project CARE
Branch Review rithviknishad/fix/send-known-bp-attrs
Run status status check passed Passed #3529
Run duration 03m 11s
Commit git commit bfd5924a32: Send only known BP attributes
Committer Rithvik Nishad
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 124
View all changes introduced in this branch ↗︎

@nihal467
Copy link
Member

nihal467 commented Oct 4, 2024

LGTM,

@khavinshankar khavinshankar merged commit 1687ced into develop Oct 4, 2024
30 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/send-known-bp-attrs branch October 4, 2024 09:35
Copy link

github-actions bot commented Oct 4, 2024

@rithviknishad @rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants