Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall react-redux and axios #8731

Merged
merged 45 commits into from
Oct 21, 2024
Merged

Uninstall react-redux and axios #8731

merged 45 commits into from
Oct 21, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 7, 2024 •
edited
Loading

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

rithviknishad and others added 21 commits August 5, 2024 17:45
@rithviknishad
Switch to using newer camera feed component and remove old components…
e5f923a 
… and utilities
@rithviknishad
remove unused code
24b41d1
@rithviknishad
Merge branch 'develop' into rithviknishad/feat/migrate-configure-camera
a62e532
@rithviknishad
Merge branch 'develop' into rithviknishad/feat/migrate-configure-camera
382983c
@rithviknishad
Merge branch 'develop' into rithviknishad/feat/migrate-configure-camera
45f4c42
@sainak
Merge remote-tracking branch 'origin/develop' into rithviknishad/feat…
3b466d6 
…/migrate-configure-camera
@rithviknishad
Merge branch 'develop' into rithviknishad/feat/migrate-configure-camera
a958669
@rithviknishad
add camera preset configure page
175ee66
@rithviknishad
update asset configure, add camera preset configure for beds
f649039
@rithviknishad
add link to camera preset configure from bed management
e744ac4
@rithviknishad
remove unused type
0601baf
@rithviknishad
use host unreachable instead of authn. error
7088f8d
@rithviknishad
Merge branch 'develop' into rithviknishad/feat/migrate-configure-camera
566e3ab
@rithviknishad
Merge branch 'develop' into rithviknishad/feat/migrate-configure-camera
046cfff
@rithviknishad
Support for configuring presets of beds from asset configure page
7ffe232
@rithviknishad
cleanup
0a7b279
@rithviknishad
adds i18n
a8be173
@rithviknishad
Merge branch 'develop' into rithviknishad/feat/migrate-configure-camera
c66e216
@rithviknishad
remove boundary preset support
b65b790
@rithviknishad
Merge branch 'develop' into rithviknishad/feat/migrate-configure-camera
06c2876
@rithviknishad
Drops all remaining usages of useDispatch
e68a637
@rithviknishad rithviknishad requested a review from a team as a code owner October 7, 2024 05:46
@netlify Netlify
Copy link

netlify bot commented Oct 7, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit df11f33
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6715d12c0f4d8b0008889451
😎 Deploy Preview https://deploy-preview-8731--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 7, 2024 •
edited
Loading

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: df11f33
Status: ✅  Deploy successful!
Preview URL: https://dbfd0118.care-fe.pages.dev
Branch Preview URL: https://rithviknishad-chore-uninstal.care-fe.pages.dev

View logs

@cypress Cypress
Copy link

cypress bot commented Oct 7, 2024 •
edited
Loading

CARE    Run #3713

Run Properties:  status check passed Passed #3713  •  git commit df11f3331d: Uninstall react-redux and axios
Project CARE
Run status status check passed Passed #3713
Run duration 03m 05s
Commit git commit df11f3331d: Uninstall react-redux and axios
Committer Rithvik Nishad
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125

@khavinshankar
Copy link
Member

@rithviknishad can you please fix the failing cypress tests

@khavinshankar khavinshankar added the cypress failed pull request with cypress test failure label Oct 7, 2024
sainak
sainak reviewed Oct 7, 2024
View reviewed changes
src/index.tsx Show resolved Hide resolved
@bodhish
Copy link
Member

bodhish commented Oct 7, 2024

Wohoo, atlast its happening 🚀

@rithviknishad rithviknishad removed the waiting for related PR a co-related detail PR is under construction label Oct 15, 2024
@rithviknishad rithviknishad changed the base branch from develop to rithviknishad/feat/migrate-configure-camera October 15, 2024 06:42
@rithviknishad rithviknishad changed the base branch from rithviknishad/feat/migrate-configure-camera to develop October 15, 2024 06:43
@github-actions GitHub Actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 15, 2024
@github-actions github-actions bot added merge conflict pull requests with merge conflict and removed merge conflict pull requests with merge conflict labels Oct 18, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Oct 18, 2024
@nihal467
Copy link
Member

LGTM

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 19, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@bodhish
Copy link
Member

bodhish commented Oct 21, 2024

@rithviknishad lets get this merged asap

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Oct 21, 2024
@khavinshankar khavinshankar merged commit 684b9ad into develop Oct 21, 2024
26 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/chore/uninstall-redux branch October 21, 2024 04:47
@github-actions GitHub Actions
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@sainak sainak Awaiting requested review from sainak

@gigincg gigincg Awaiting requested review from gigincg

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress passed tested
Projects
None yet
Milestone
No milestone
5 participants
@rithviknishad @khavinshankar @bodhish @nihal467 @sainak