Prevent infinite load when avatar upload fails #8881
Conversation
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rithviknishad
changed the title
|
When a user attempts to upload a non-permitted image, the system currently throws an error and closes the entire pop-up. This should not be the expected behavior. Instead, the user should remain on the same pop-up, where the error message is displayed, allowing them to re-select and upload an appropriate image. |
Made some changes and this is how it works now: Recording.2024-10-23.144048.mp4 |
| try { | ||
| await handleUpload(selectedFile, () => { | ||
| setSelectedFile(undefined); | ||
| setPreview(undefined); | ||
| setPreviewImage(null); | ||
| }); | ||
| } catch (e) { | ||
| console.error(e); | ||
| } finally { | ||
| setIsCaptureImgBeingUploaded(false); | ||
| setIsProcessing(false); | ||
| }); | ||
| } |
There was a problem hiding this comment.
These changes are not required, just calling onError() in the handler should be enough
There was a problem hiding this comment.
Done, I removed them.
Is it ok now?
|
it's still stuck in infinite loading :/ 
|
|
👋 Hi, @nithish1018, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
I checked it again and it's working fine 🤔 Recording.2024-10-23.162712.mp4 |
|
@nithish1018 can you try updating the profile pic instead of facility cover image? |
Thank you, I added the fix for it |
|
clear merge conflicts; rest lgtm |
rithviknishad
added
needs testing
and removed
changes required
merge conflict
|
LGTM |
|
@nithish1018 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist