Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicated content in patient consultation #9221

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Fix duplicated content in patient consultation #9221

merged 2 commits into from
Nov 27, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Nov 27, 2024 •
edited by coderabbitai bot
Loading

Proposed Changes

  • Fixes content duplicating on consultation page

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • Refactor
    • Simplified the structure of the ConsultationDetails component by removing a redundant <div> wrapper around the SelectedTab component, enhancing layout without affecting functionality.

@shivankacker shivankacker requested a review from a team as a code owner November 27, 2024 10:02
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2024 •
edited
Loading

Walkthrough

The changes in this pull request focus on the ConsultationDetails component by removing a redundant <div> wrapper around the SelectedTab component. This modification simplifies the component's structure while preserving its existing functionality, including state management and rendering logic. The overall control flow and error handling remain unchanged, ensuring consistent user experience.

Changes

File Change Summary
src/components/Facility/ConsultationDetails/index.tsx Removed redundant <div> wrapper around SelectedTab, simplifying structure without altering functionality.

Possibly related PRs

  • Fix bug with recursion #9100: This PR modifies the ConsultationDetails component, which is directly related to the changes made in the main PR that also affects the ConsultationDetails component in the same file. Both PRs involve structural changes to the component's management and rendering logic.

Suggested labels

needs review, tested

Suggested reviewers

  • rithviknishad

Poem

In the land of code where rabbits play,
A <div> was removed to brighten the day.
With tabs that now shine, so neat and so bright,
Our ConsultationDetails feels just right! 🐇✨
Hopping along, we simplify,
In the world of components, we reach for the sky!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Nov 27, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 84c7c1c
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/674714800854d40008ac088c
😎 Deploy Preview https://deploy-preview-9221--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shivankacker shivankacker self-assigned this Nov 27, 2024
@shivankacker shivankacker added needs testing needs review P1 breaking issue or vital feature labels Nov 27, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 27, 2024 •
edited
Loading

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 84c7c1c
Status: ✅  Deploy successful!
Preview URL: https://326f489e.care-fe.pages.dev
Branch Preview URL: https://selected-tab-fix.care-fe.pages.dev

View logs

@cypress Cypress
Copy link

cypress bot commented Nov 27, 2024 •
edited
Loading

CARE    Run #3962

Run Properties:  status check passed Passed #3962  •  git commit 84c7c1c9ae: Fix duplicated content in patient consultation
Project CARE
Branch Review selected-tab-fix
Run status status check passed Passed #3962
Run duration 05m 28s
Commit git commit 84c7c1c9ae: Fix duplicated content in patient consultation
Committer Shivank Kacker
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 135
View all changes introduced in this branch ↗︎

@nihal467
Copy link
Member

LGTM

@rithviknishad rithviknishad merged commit 8b02709 into develop Nov 27, 2024
55 checks passed
@rithviknishad rithviknishad deleted the selected-tab-fix branch November 27, 2024 13:06
@github-actions GitHub Actions
Copy link

@shivankacker @shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@coderabbitai coderabbitai bot mentioned this pull request Nov 29, 2024
Closed
6 tasks
UdaySagar-Git pushed a commit to UdaySagar-Git/care_fe that referenced this pull request Dec 3, 2024
@shivankacker @UdaySagar-Git
Fix duplicated content in patient consultation (ohcnetwork#9221)
323e646
This was referenced Dec 5, 2024
Merged
Merged
This was referenced Dec 12, 2024
Merged
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacobjeevan Jacobjeevan Jacobjeevan approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees

@shivankacker shivankacker

Labels
P1 breaking issue or vital feature tested
Projects
Care
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shivankacker @nihal467 @rithviknishad @Jacobjeevan