Fix : Facility name in facility users page #9746

Mahendar0701 · 2025-01-04T14:25:22Z

Proposed Changes

Fixes Facility name is shown as undefined in facility user page #9744
Displayed correct facility name in facility users page
More?

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

Refactor
- Updated data fetching logic in the FacilityUsers component to use standard @tanstack/react-query hooks.
- Improved query management for user data fetching with a new query key.
- Optimized query execution with conditional loading based on facility ID.
- Enhanced internationalization support for user-not-found messages.

coderabbitai · 2025-01-04T14:25:30Z

Walkthrough

The pull request refactors the FacilityUsers component in the src/components/Facility/FacilityUsers.tsx file, transitioning from a custom query hook to the standard useQuery hook from @tanstack/react-query. The changes focus on improving data fetching for facility and user list data by using more standardized query methods with explicit query keys and functions. The implementation ensures queries are only executed when a facility ID is available.

Changes

File	Change Summary
`src/components/Facility/FacilityUsers.tsx`	Replaced custom query hook with `useQuery` for fetching user list data; updated no users found message to use translation; simplified page title.

Assessment against linked issues

Objective	Addressed	Explanation
Resolve undefined facility name [#9744]	❌	The changes do not address the display of the facility name, which remains undefined.

Possibly related PRs

Fixed facility selection issue in UserAddEditForm #9503: The changes in this PR involve the UserAddEditForm component, which may relate to the FacilityUsers component in terms of user management and data handling, although they focus on different aspects of user data.

Suggested labels

needs review, tested, P1

Suggested reviewers

Jacobjeevan
rithviknishad

Poem

🐰 Queries dance with grace and might,
TanStack's magic takes its flight!
From custom hooks to standard way,
Data fetching finds its play.
Facility users, clear and bright! 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9261c5b and df72deb.

📒 Files selected for processing (1)

src/components/Facility/FacilityUsers.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/Facility/FacilityUsers.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-04T14:25:40Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`2fe792d`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67795b10abb7ed0008d82740
😎 Deploy Preview	https://deploy-preview-9746--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Facility/FacilityUsers.tsx (1)
24-30: Consider handling loading/error states for facility data.

While you handle the user list’s loading state and absence of data, there is no explicit handling for the facility data failing to load or returning undefined. You may want to add a separate check to prevent displaying incomplete facility information.

Here is a possible approach:
  if (userListLoading) {
    return <div>Loading...</div>;
  }
+ if (!facilityData) {
+   return <div>{t("facility_not_available")}</div>;
+ }
  if (!userListData) {
    return <div>No users found</div>;
  }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 68c4c3d and 4765368.

📒 Files selected for processing (1)

src/components/Facility/FacilityUsers.tsx (1 hunks)

bodhish · 2025-01-04T14:50:22Z

Why do we need the facility name inside that page? 🤔

Jacobjeevan · 2025-01-04T15:10:18Z

Why do we need the facility name inside that page? 🤔

It's from old layout, but yea we could remove that since it will be highlighted in the sidebar anyways.

bodhish · 2025-01-04T15:15:07Z

lets clean up facility name.

Mahendar0701 · 2025-01-04T15:31:11Z

@bodhish @Jacobjeevan removed facility name

bodhish

LGTM

github-actions · 2025-01-04T16:02:22Z

@Mahendar0701 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

facility name in users page

4765368

Mahendar0701 requested a review from a team as a code owner January 4, 2025 14:25

coderabbitai bot reviewed Jan 4, 2025

View reviewed changes

Jacobjeevan added needs testing needs review labels Jan 4, 2025

Jacobjeevan approved these changes Jan 4, 2025

View reviewed changes

translation

9261c5b

bodhish added changes required and removed needs testing needs review labels Jan 4, 2025

removed facility name

df72deb

Mahendar0701 requested a review from Jacobjeevan January 4, 2025 15:31

bodhish approved these changes Jan 4, 2025

View reviewed changes

Merge branch 'develop' into facility-undefined

2fe792d

bodhish merged commit 4850743 into ohcnetwork:develop Jan 4, 2025
11 checks passed

Mahendar0701 deleted the facility-undefined branch January 4, 2025 16:08

This was referenced Jan 4, 2025

Fixed : User Search Bar #9750

Open

Care Loading icon in organization and facility users #9723

Merged

AdityaJ2305 pushed a commit to AdityaJ2305/care_fe that referenced this pull request Jan 5, 2025

Remove facility name from facility users page (ohcnetwork#9746)

00f1150

This was referenced Jan 5, 2025

Fix : Switch to using CreateFacilityForm #9662

Draft

Fix Online Status Indicator in Organization Tab #9728

Merged

Fix the Facilties tab overflow in Organization Layout #9778

Open

Public Facilities Filters #9748

Open

khavinshankar pushed a commit that referenced this pull request Jan 8, 2025

Remove facility name from facility users page (#9746)

ff52370

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix : Facility name in facility users page #9746

Fix : Facility name in facility users page #9746

Mahendar0701 commented Jan 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 4, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 4, 2025 •

edited

Loading

coderabbitai bot left a comment

bodhish commented Jan 4, 2025

Jacobjeevan commented Jan 4, 2025

bodhish commented Jan 4, 2025

Mahendar0701 commented Jan 4, 2025

bodhish left a comment

github-actions bot commented Jan 4, 2025

Fix : Facility name in facility users page #9746

Fix : Facility name in facility users page #9746

Conversation

Mahendar0701 commented Jan 4, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Jan 4, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 4, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

bodhish commented Jan 4, 2025

Jacobjeevan commented Jan 4, 2025

bodhish commented Jan 4, 2025

Mahendar0701 commented Jan 4, 2025

bodhish left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 4, 2025

Mahendar0701 commented Jan 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 4, 2025 •

edited

Loading