Click annotations handler #1
Conversation
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
| @@ -21,6 +21,8 @@ import { | |||
| HOVER_PARAM, | |||
| } from '../'; | |||
|
|
|||
| const showEventsFlyoutAction = 'show-events-flyout'; | |||
There was a problem hiding this comment.
Do you want to take on the view events flyout action, or just have the framework set up that I can build on top of? For example I already have the defined open flyout action in my draft PR here: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3415/files#diff-e5581c4c9ed88d345c2fffa25e66f906e98b05d699e4c5614a87748e31996d4d
| { | ||
| event: 'click', | ||
| expressionFunction: 'visAugmenter.handlePointInTimeClick', | ||
| }, |
There was a problem hiding this comment.
Recommend making the interaction handler an interface / typesafe. Also, expressionFunction field could be renamed to just function or something else, since it is not an expression function.
| export const isPointInTimeView = (item: any) => { | ||
| return item.datum.action === showEventsFlyoutAction; | ||
| }; |
There was a problem hiding this comment.
not sure if you've played around much with the different scenarios, but what happens if user clicks at a blank space in the chart, or somewhere irrelevant within the canvas? (axes, legend, etc.). I'm assuming datum would be empty, or action within datum would be empty, if clicking on other datapoints.
| }; | ||
|
|
||
| export const addPointInTimeInteractionHandlers = (spec: any) => { | ||
| spec.interactionHandlers = [ |
There was a problem hiding this comment.
we can probably add this field as a nested field in kibana, which is used in the vega parser to process things within the spec that aren't specific to vega itself. ref: opensearch-project#3145 (comment)
ohltyler
force-pushed
the
add-annotations
branch
2 times, most recently
from
4fa4d70 to
3f4e1e1
Compare
Description
Adds small framework to allow adding event handlers on vega visualizations.
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr