Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

themes/luan: Show Python virtualenv #393

Closed
wants to merge 1 commit into from

Conversation

Askaiant
Copy link
Contributor

@Askaiant Askaiant commented Feb 4, 2023

Edited the prompt so it shows the active python virtualenv to the user when it is active.

@akinomyoga
Copy link
Contributor

Thanks for the contribution. I have been thinking that what would be shown in the prompt would largely depend on personal preferences, so I have been marking the PRs that try to add an element to the prompt as customization examples. However, particularly for the virtualenv and the condaenv, we have so many similar PRs including this one, #387, #373, #335, and #282.

Now maybe we should introduce a configuration variable like OMB_PROMPT_SHOW_PYTHON_VENV=true, etc., and include the venv elements in all the themes. One non-trivial stuff is that we need to carefully choose the design of the new element that matches each theme one by one. Hmm, maybe we can give up supporting it all at once and separately apply PRs to the themes that the PR has appeared.

@Askaiant
Copy link
Contributor Author

Askaiant commented Feb 7, 2023

I see what you mean. I will close this PR in place of #394. This way we could give the option to personalize whether the prompt is shown or not. As for including the element in the theme, this could be done progressively per request (e.g. #372 , #117 , #210 , #387 , #373 and #335 ) but would have to somehow match the style, would be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants