Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

themes: Add theme edsonarios #481

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

edsonarios
Copy link
Contributor

My reasons for this new topic.
I usually always install oh-my-bash to start with a new machine or virtual or cloud environment, so I like to have all its functionalities quickly, principally git plugin
My customizations:

  • I like to see what time I execute my last command
  • I like to see only a (*) when there is a change, I only need that, because if I want to know the details or how many files are pending, I just run "gst"
  • Sometimes I work with python, and it is good to know if I have the environment activated so as not to make mistakes
  • If a command is not executed properly, it is good to see it in a different color
  • My main reason is to be able to see the exact route of where I am, because sometimes I work on multiple versions of the same project and not seeing the complete route usually confuses me
  • And finally if I am in my HOME directory, I like to see only "~/", this is useful in windows, because if you use the traditional way it shows something like "/c/Users/name" and it is unnecessary information

image

I hope that the next time I install oh-my-bash I only need to change the theme name, to have my customizations, thank you very much 😊

Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

Could you prepare the image in the size of about 290x700? You should also update themes/THEMES.md. They are actually described in CONTRIBUTING.md:

When you add new themes, please also update themes/THEMES.md. The theme needs to have exactly one image of height ~290px and width 600--800px. After your new themes are merged, the list in Themes in the Wiki also needs to be updated.

themes/edsonarios/edsonarios.theme.sh Show resolved Hide resolved
themes/edsonarios/edsonarios.theme.sh Outdated Show resolved Hide resolved
themes/edsonarios/edsonarios.theme.sh Outdated Show resolved Hide resolved
themes/edsonarios/edsonarios.theme.sh Outdated Show resolved Hide resolved
@akinomyoga
Copy link
Contributor

  • And finally if I am in my HOME directory, I like to see only "~/", this is useful in windows, because if you use the traditional way it shows something like "/c/Users/name" and it is unnecessary information

This background information is non-trivial, so it is better to also include the information in a code comment on the corresponding code.

@edsonarios
Copy link
Contributor Author

Thanks for your comments, I updated my PR with the observations, I hope I have resolved them to your satisfaction. Any other comments, I will be happy to resolve them, thank you very much.

@akinomyoga
Copy link
Contributor

Thank you for updating. I've pushed additional fixes. Could you check these?

akinomyoga
akinomyoga previously approved these changes Oct 3, 2023
@edsonarios
Copy link
Contributor Author

All good, thanks so much

edsonarios and others added 4 commits October 4, 2023 08:09
show complete work route, show simple git changes and actual time,
write commands in new simple line, and show output error.
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking!

@akinomyoga akinomyoga merged commit f6c8e3a into ohmybash:master Oct 3, 2023
4 checks passed
@akinomyoga
Copy link
Contributor

I've merged. Could you also edit the wiki page of themes?

@edsonarios
Copy link
Contributor Author

Sure

@akinomyoga akinomyoga changed the title themes/new-theme themes: Add theme edsonarios Oct 3, 2023
@edsonarios
Copy link
Contributor Author

Done, thanks

@akinomyoga
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants