Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aliases/git: Move git plugin aliases to their own file #605

Closed
wants to merge 1 commit into from

Conversation

RobLoach
Copy link
Contributor

@RobLoach RobLoach commented Sep 5, 2024

In an attempt to fix the issue brought up in #470, this moves the aliases defined in the git plugin to their own git aliases file.

It allows having the git shell functions, while keeping the git aliases disabled.

@akinomyoga
Copy link
Contributor

Hmm, I'm opposed to this change. A significant number of users use this plugin since it is enabled by default in Oh My Bash (OMB). So the compatibility issue that I raised in #602 applies here even more . Even if we forget about the compatibility issue, this breaks correspondence to the upstream OMZ plugin git.

Also, many of the left functions are actually helper functions used to implement the aliases. These aliases depend on shell functions, such as git_{current,main,develop}_branch. I also suspect that the other functions are for similar purposes. In that sense, this move of the partial content breaks the aliases relying on them.

@RobLoach
Copy link
Contributor Author

RobLoach commented Sep 5, 2024

Sounds good with me 👍

@RobLoach RobLoach closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants