Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tables for samples below cutoffs #74

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Conversation

apmasell
Copy link
Contributor

@apmasell apmasell commented Dec 9, 2019

No description provided.

Copy link
Contributor

@callunity callunity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the cutoff number be displayed in the table header?
What do you think about making the table collapsible, or some other way of making it so you don't have to scroll through 100+ rows to get to the next table?
It doesn't look like this table is displaying the same number of rows as are available in the "all samples data" table below. For instance, selecting all runs in pre-RNA results in an "all samples data" table with three rows for BTC, two of which are the same sample with a different IUS, and one which is separate. The cutoffs table displays only one row for BTC.

@apmasell
Copy link
Contributor Author

apmasell commented Dec 9, 2019

It's intentionally not showing all the samples, but only the ones with failures; if everything passes, the sample is excluded.

There's no pre-built collapsible sections, but there are tabs. Does it make sense to flip between the failures and all the data (and that gives them headers too)?

Did you want the failing values in those cells too?

@callunity
Copy link
Contributor

Ah, then in that case I like the idea of tabs, as I can't imagine them wanting to view both tables at once, and it gives us convenient labelling of the tables.

I agree, users will probably want to see failing values in the cells

@apmasell
Copy link
Contributor Author

apmasell commented Dec 9, 2019

Okay. Tabs and values added.

@callunity
Copy link
Contributor

The "Raw Data" tab takes 3+ seconds to load when all runs are selected, and there's no indication to the user that something is happening during this time. Does it make things clearer to the user if the tables are wrapped in Loading spinners?

Also, the tables are displaying as monospaced on pre-WGS and regular font on pre-RNA and pre-EX. Can this be standardized? I'm partial to regular font.

@apmasell
Copy link
Contributor Author

Fixed the fonts, added spinners, and I moved more of the functionality into reused code.

@callunity
Copy link
Contributor

Fonts look great and I like the code reuse, but I'm not seeing the spinners -- it just looks like nothing is happening for 3-4 seconds after clicking "Raw Data" (on pre-WGS + all runs).

@apmasell
Copy link
Contributor Author

Apparently you're not supposed to use tabs without callbacks. You get no loading animations and slow switching between tabs. plotly/dash-core-components#256

@apmasell apmasell merged commit dfbf485 into master Dec 10, 2019
@apmasell apmasell deleted the GR-934_failed_cutoffs branch December 10, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants