Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make spec test format stricter #143

Closed
2 tasks
andychu opened this issue Jun 6, 2018 · 1 comment
Closed
2 tasks

Make spec test format stricter #143

andychu opened this issue Jun 6, 2018 · 1 comment
Labels
good first issue help wanted

Comments

@andychu
Copy link
Contributor

andychu commented Jun 6, 2018

  • all metadata lines should begin with ##, not # to prevent confusion with actual shell comments
  • all test case lines can move to #### and not ###, for aesthetics

NOTE: ping if you start this, because I might do this with somebody who wants to learn shell. It's grep/sed/regexes.
@andychu
Copy link
Contributor Author

andychu commented Jun 24, 2018

NOTE: doing this somewhat depends on issue #42 . Although if all the spec tests pass on your machine before and after, that seems OK.

andychu pushed a commit that referenced this issue Jul 2, 2018
@andychu
Use a new, stricter format for the spec tests (#156)
46c3840 
- Test metadata always begins with `##`, which makes it less likely for us to confuse them with real comments.
- Test headers begin with `####` for aesthetics`.

Fixes issue #143.

Also:

- Update alias spec test so it's less likely to conflict with commands in $PATH (address issue #22)
@andychu andychu closed this as completed Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andychu