crash with double quoted zsh var in osh

[lincheney]

Hi,

I accidentally ran some zsh inside osh (0.26.0) and it causes it to crash:

osh-0.26.0$ echo "${(P)1}"
osh: _gen/bin/oils_for_unix.mycpp.cc:48905: syntax_asdl::word_part_t* word_parse::WordParser::_ReadDoubleQuotedLeftParts(): Assertion `0' failed.
[1]    171786 IOT instruction (core dumped)  ./_bin/cxx-opt-sh/osh

interestingly it's ok without the double quotes i.e. it prints an error rather than crashing

osh-0.26.0$ echo ${(P)1}
  echo -n ${(P)1}
          ^~~~~
[ interactive ]:1: fatal: ZSH var subs are parsed, but can't be evaluated

[andychu]

Ah yes I can reproduce this -- the double quoted case has a bug, and should behave like the other code

Thanks for the report!

  File "/home/andy/git/oils-for-unix/oils/osh/word_parse.py", line 780, in _ReadDoubleQuotedLeftParts
    raise AssertionError(self.cur_token)
AssertionError: (Token
  id:Left_DollarBraceZsh
  length:5
  col:6
  line:(SourceLine line_num:1 content:"echo \"${(P)1}\"" src:(source.CFlag))
)

[andychu]

I just fixed this, it will be out with the next release

Thanks for the report!