Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for signed URLs #129

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Initial support for signed URLs #129

merged 1 commit into from
Jan 29, 2022

Conversation

oittaa
Copy link
Owner

@oittaa oittaa commented Jan 29, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2022

Codecov Report

Merging #129 (67a9ee5) into main (1956d44) will increase coverage by 0.08%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   87.42%   87.51%   +0.08%     
==========================================
  Files           7        7              
  Lines         851      857       +6     
  Branches      117      116       -1     
==========================================
+ Hits          744      750       +6     
- Misses         80       81       +1     
+ Partials       27       26       -1     
Flag Coverage Δ
unittests 87.51% <77.77%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gcp_storage_emulator/handlers/objects.py 88.02% <75.00%> (-0.38%) ⬇️
gcp_storage_emulator/server.py 85.87% <100.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1956d44...67a9ee5. Read the comment docs.

@oittaa
Copy link
Owner Author

oittaa commented Jan 29, 2022

Now two of the most common cases should be supported: downloading and uploading with the signed URLs. #128

@oittaa oittaa merged commit 646ea0c into main Jan 29, 2022
@oittaa oittaa deleted the signed_urls branch January 29, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants