Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload_from_file with "application/json" #162

Merged
merged 1 commit into from
Apr 9, 2022
Merged

Fix upload_from_file with "application/json" #162

merged 1 commit into from
Apr 9, 2022

Conversation

oittaa
Copy link
Owner

@oittaa oittaa commented Apr 9, 2022

Fixes #161

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2022

Codecov Report

Merging #162 (de0a856) into main (b0a6d35) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   88.00%   88.01%   +0.01%     
==========================================
  Files           7        7              
  Lines         875      876       +1     
  Branches      121      122       +1     
==========================================
+ Hits          770      771       +1     
  Misses         77       77              
  Partials       28       28              
Flag Coverage Δ
unittests 88.01% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gcp_storage_emulator/server.py 85.87% <100.00%> (ø)
gcp_storage_emulator/storage.py 94.17% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0a6d35...de0a856. Read the comment docs.

@oittaa oittaa merged commit 48d9c83 into main Apr 9, 2022
@oittaa oittaa deleted the json-upload branch April 9, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upload_from_file() with content type "application/json" not working
2 participants