Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve #97 && log format with config. #98

Merged
merged 4 commits into from
Aug 7, 2024
Merged

resolve #97 && log format with config. #98

merged 4 commits into from
Aug 7, 2024

Conversation

Zztrans
Copy link
Member

@Zztrans Zztrans commented Aug 5, 2024

  1. data clean script which desire to be a reverse effect of init. The Makefile may be refined.

  2. A logger format which can be control in config.toml

Current logger like, which we can easily locate in vscode.

INFO[2024-08-06 00:10:22] Remove Minio Objects success                  caller="/home/zztrans/src/ojlab/oj-lab-platform/cmd/clean/main.go:44"
INFO[2024-08-06 00:10:22] Casbin enforcer watcher initialized           caller="/home/zztrans/src/ojlab/oj-lab-platform/modules/agent/casbin/enforcer.go:56"

@Zztrans Zztrans requested a review from slhmy August 5, 2024 16:19
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.78%. Comparing base (6e9b71d) to head (d685cd7).

Files Patch % Lines
modules/log/log.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   29.27%   29.78%   +0.51%     
==========================================
  Files          35       35              
  Lines        1042     1051       +9     
==========================================
+ Hits          305      313       +8     
- Misses        689      690       +1     
  Partials       48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makefile Show resolved Hide resolved
modules/log/log.go Show resolved Hide resolved
@Zztrans
Copy link
Member Author

Zztrans commented Aug 6, 2024

Refs #97 .

Updated, according to request.

@Zztrans Zztrans requested a review from slhmy August 7, 2024 01:39
Copy link
Member

@slhmy slhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@slhmy slhmy merged commit 4a1f86f into main Aug 7, 2024
4 checks passed
@Zztrans Zztrans deleted the zztrans/main branch September 28, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants