Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fin provider #42

Merged
merged 9 commits into from
Mar 9, 2023
Merged

feat: fin provider #42

merged 9 commits into from
Mar 9, 2023

Conversation

adamewozniak
Copy link
Member

@adamewozniak adamewozniak commented Feb 24, 2023

Description

This brings the fin provider over from kujira's fork of our price feeder :^)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@adamewozniak
Copy link
Member Author

This provider is definitely a beta - according to kujira they've had issues with validators getting blocked on their cloudflare. We'll likely have to follow up on this with a polling implementation.

@adamewozniak adamewozniak marked this pull request as ready for review March 1, 2023 19:13
@adamewozniak adamewozniak requested a review from a team as a code owner March 1, 2023 19:13
oracle/provider/fin.go Show resolved Hide resolved
oracle/provider/fin_test.go Outdated Show resolved Hide resolved
@adamewozniak adamewozniak requested a review from rbajollari March 9, 2023 16:20
@adamewozniak adamewozniak merged commit ef1b51e into main Mar 9, 2023
@adamewozniak adamewozniak deleted the woz/fin branch March 9, 2023 16:47
@adamewozniak
Copy link
Member Author

@Mergifyio backport umee

@mergify
Copy link

mergify bot commented Apr 10, 2023

backport umee

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 10, 2023
* Make Sure You Are Square With Your God Before Trying To Merge This

(cherry picked from commit ef1b51e)
adamewozniak pushed a commit that referenced this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants