Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): better SEO for images and package playground #92

Merged
merged 24 commits into from
Dec 4, 2022

Conversation

ojvribeiro
Copy link
Owner

@ojvribeiro ojvribeiro commented Nov 8, 2022

Fixes 86, Fixes #89, Resolves #91, Fixes #100.

@ojvribeiro ojvribeiro added bug Something isn't working enhancement New feature or request labels Nov 8, 2022
@ojvribeiro ojvribeiro self-assigned this Nov 8, 2022
@ojvribeiro
Copy link
Owner Author

Since (for the time I'm writing this) there's no known way to automatically guess the image aspect-ratio to prevent Cumulative Layout Shift (CLS), maybe it is a better choice to remove automatic width and height attributes from the Image component and let that job for the user. This means "no Lighthouse outta-the-box 100% performance score". 😭

@ojvribeiro
Copy link
Owner Author

I think the best choice, for now, is to reduce the scope for the Image component to perform the WebP replacement only. A possible future path is also deprecate the component in order to reduce the framework total size and MAYBE turn it into a separate module.

@ojvribeiro
Copy link
Owner Author

#89 seems to be fixed since version 1.0.10 of laravel-mix-simple-image-processing

Refer to this issue on the package repo: TristanMouchet/laravel-mix-simple-image-processing#8

@ojvribeiro ojvribeiro marked this pull request as ready for review November 17, 2022 19:32
@ojvribeiro ojvribeiro merged commit b309ede into main Dec 4, 2022
@ojvribeiro ojvribeiro deleted the fix-image-lighthouse branch December 4, 2022 22:42
@ojvribeiro ojvribeiro mentioned this pull request Dec 14, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
1 participant