consistency, black_white_list: fix invalid config option `consistency…

…` and improve style (pingcap#42) * fix invalid config option * black_white_list: improve style
okJiang · Mar 9, 2020 · 65b93cc · 65b93cc
1 parent 58ad92c
commit 65b93cc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/cmd/dumpling/main.go b/cmd/dumpling/main.go
@@ -92,6 +92,7 @@ func run() {
 	conf.FileSize = fileSize
 	conf.StatementSize = statementSize
 	conf.OutputDirPath = outputDir
+	conf.Consistency = consistency
 	conf.NoViews = noViews
 
 	err = export.Dump(conf)

diff --git a/v4/export/black_white_list.go b/v4/export/black_white_list.go
@@ -1,15 +1,13 @@
 package export
 
 import (
-	"strings"
-
 	"github.com/pingcap/dumpling/v4/log"
 	"github.com/pingcap/tidb-tools/pkg/filter"
 	"go.uber.org/zap"
 )
 
 type BWList interface {
-	Apply(string, string) bool
+	Apply(schema string, table string) bool
 }
 
 type BWListMode byte
@@ -66,7 +64,7 @@ func filterDirtySchemaTables(conf *Config) {
 	switch conf.ServerInfo.ServerType {
 	case ServerTypeTiDB:
 		for dbName := range conf.Tables {
-			if filter.IsSystemSchema(strings.ToLower(dbName)) {
+			if filter.IsSystemSchema(dbName) {
 				log.Zap().Warn("unsupported dump schema in TiDB now", zap.String("schema", dbName))
 				delete(conf.Tables, dbName)
 			}