Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow creation of DM with yourself #2002

Closed
taoeffect opened this issue May 21, 2024 · 5 comments · Fixed by #2343
Closed

Allow creation of DM with yourself #2002

taoeffect opened this issue May 21, 2024 · 5 comments · Fixed by #2343
Assignees
@SebinSong
Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:UI/UX

Comments

@taoeffect
Copy link
Member

Problem

It is very useful to be able to create a DM with yourself to share and remember notes with yourself.

Right now we can't do this because the DM creation modal doesn't show your username in it.

Solution

  • Allow creating a DM to yourself.
  • If a DM is created between you and some other people, treat it the same way as we do right now with creating a DM with those other people (just ignore the fact that you're also listed in the DM - you are obviously are going to be part of the conversation).
@taoeffect taoeffect added Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:Up-for-grabs App:Frontend Note:UI/UX labels May 21, 2024
@SebinSong SebinSong self-assigned this May 22, 2024
@SebinSong
Copy link
Collaborator

SebinSong commented Sep 3, 2024 •
edited
Loading

Hi @taoeffect ,
As a solution for this issue, how would you like that we add To: @Me button underneath the search bar, instead of showing the current user in the "Others" list below? (I feel this can be a solution that brings the least amount of complexity to the existing logic and can make the feature stand out to the users at the same time)

image

@taoeffect
Copy link
Member Author

@SebinSong No, I'm not a fan of complicating the UI. I am a fan of simplifying the UI. If, for example, you prefer to get rid of "Recent Conversations" and "Others" and just have a list of users (and convos?) in the list, that works too.

My preference would be to treat your user as anyone else.

@SebinSong
Copy link
Collaborator

@taoeffect

My preference would be to treat your user as anyone else.

Got it!

@SebinSong
Copy link
Collaborator

@taoeffect
Below is the welcome message printed after a DM is created. What would you like it to say for the case of DM to myself?

SebinSong added a commit that referenced this issue Sep 6, 2024
@SebinSong
Merge remote-tracking branch 'origin/master' into sebin/task/#2002-al…
3c004b2 
…low-dm-to-yourself
@taoeffect
Copy link
Member Author

taoeffect commented Sep 6, 2024 •
edited
Loading

Good question! How about: You can post private notes to yourself here.

SebinSong added a commit that referenced this issue Sep 8, 2024
@SebinSong
Merge remote-tracking branch 'origin/master' into sebin/task/#2002-al…
097c9cc 
…low-dm-to-yourself
SebinSong added a commit that referenced this issue Sep 10, 2024
@SebinSong
Merge remote-tracking branch 'origin/master' into sebin/task/#2002-al…
7012e53 
…low-dm-to-yourself
@SebinSong SebinSong mentioned this issue Sep 10, 2024
Merged
taoeffect pushed a commit that referenced this issue Sep 12, 2024
@SebinSong
#2002 allow DM to yourself (#2343)
ca27856 
* update NewDirectMessageModal.vue so it knows when to create a self-DM

* make it possible to create a chatroom with 1 member

* Add todo comment

* hide add-people cta for DM-to-myself

* some fixes

* DRY DM getters / prevent duplicate DM-to-myself from being generated

* remove debug console

* update chat greeting message for dm-to-myself

* remove DM todo comment in the source-code

* some clean-up

* restore the broken logic re searchText

* fix the logic to determine dm-to-myself

* fix the greyed-out photo issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebinSong SebinSong

Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2002 allow DM to yourself okTurtles/group-income
2 participants
@taoeffect @SebinSong