Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] dynamic generation of children causes overflow #4

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[fix] dynamic generation of children causes overflow #4

merged 1 commit into from
Jun 28, 2023

Conversation

zsakvo
Copy link
Contributor

@zsakvo zsakvo commented Jun 27, 2023

If the components within its children are dynamically generated, there might be index errors occurring because the internal children are only built during initialization and are not handled for updates.

okaryo
okaryo approved these changes Jun 28, 2023
View reviewed changes
Copy link
Owner

@okaryo okaryo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@okaryo okaryo merged commit b708ee2 into okaryo:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okaryo okaryo okaryo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zsakvo @okaryo