features: installer artifacts build paralleled, do not build up-to-date images #39
Conversation
…FILES_FROM_REPO_GLOB
it seems ADDITIONAL_BIN_FOLDER_FROM_REPO is used instedof ADDITIONAL_FILES_FROM_REPO_GLOB
…FILES_FROM_REPO_GLOB
…FILES_FROM_REPO_GLOB, fix double quites on copy additional bins
…ld to particular builds
There was a problem hiding this comment.
Hi @dsevost , I apologize again for the substantial delay. The code overall is good. However, I'm unsure if we can deviate from the Prow Builds definitions today and successfully maintain this repo.
I would make two/three PRs from this large one:
- General fixes (for builder-replacement, buildArgs, and other kustomization patches, and to update fedora ISTags)
- The new feature to avoid rebuilding from scratch everytime and only build the outdated projects
- Changes to the way the installer-artifacts are built (but, as anticipated, I'm not sure this is ok to be done now, I'd also ask an opinion from @vrutkovs).
| type: Local | ||
| importPolicy: | ||
| importMode: PreserveOriginal # Needs OKD 4.13 | ||
| # upstream already resides on fedora:37 (Dockerfile.okd -> Dockerfile.fcos) |
There was a problem hiding this comment.
I'd add the fedora:3[78] ISTags.
| @@ -57,6 +56,7 @@ spec: | |||
| value: > | |||
| OpenShift is a platform for developing, | |||
| building, and deploying containerized applications. | |||
| # are these tag really necessary here? | |||
There was a problem hiding this comment.
If I remember correctly these are replaced later with the okd ones and are needed for some specific code to be considered for OKD vs OCP vs OKD/SCOS. I'm not sure if this is needed for the cli too though, @vrutkovs ?
| @@ -25,6 +25,7 @@ spec: | |||
| imageOptimizationPolicy: SkipLayers | |||
| dockerfilePath: images/baremetal/Dockerfile.centos9 | |||
| buildArgs: | |||
| # are these tag really necessary here? | |||
| metadata: | ||
| name: installer-artifact-amd64-lnx | ||
| labels: | ||
| part-of-artifacts: installer |
There was a problem hiding this comment.
I'm not sure this is ideal at this time. Deviating from the prow builds definitions may be a future step. However, the maintenance of the repo might become harder including these changes..
| name: 'tools:fedora36' | ||
| as: | ||
| - 'fedora:35' | ||
| # - from: |
There was a problem hiding this comment.
Either delete or update, I'd avoid commenting. I'd prefer updating as per the previous comment.
| @@ -10,31 +11,103 @@ spec: | |||
| - name: max_concurrent_builds | |||
| type: string | |||
| default: "8" | |||
| - name: build_outdated_only | |||
There was a problem hiding this comment.
Can we get the changes regarding this feature in a separate PR?
hello, dear okd-team,
please review the pull-req
features added:
update: also included
okd-rpmscontent places intorelease:artifacts