Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RAM issue #102

Merged
merged 7 commits into from
Apr 6, 2021
Merged

Fix RAM issue #102

merged 7 commits into from
Apr 6, 2021

Conversation

oke-aditya
Copy link
Owner

@oke-aditya oke-aditya commented Apr 5, 2021

We should lazy load models, this is major fix for memory leak.

I will also need to do release 0.2.1 for this

@oke-aditya oke-aditya self-assigned this Apr 5, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #102 (f938101) into master (0a29870) will increase coverage by 0.21%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   77.14%   77.35%   +0.21%     
==========================================
  Files          50       50              
  Lines        1584     1568      -16     
==========================================
- Hits         1222     1213       -9     
+ Misses        362      355       -7     
Flag Coverage Δ
unittests 77.35% <80.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
quickvision/pretrained/_model_zoo.py 100.00% <ø> (ø)
...kvision/models/components/torchvision_backbones.py 90.38% <75.00%> (+8.29%) ⬆️
...kvision/models/classification/cnn/model_factory.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a29870...f938101. Read the comment docs.

@oke-aditya oke-aditya merged commit beafe77 into master Apr 6, 2021
@oke-aditya oke-aditya deleted the fix_pr branch April 6, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant