Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finishes Detr #21

Merged
merged 5 commits into from
Nov 11, 2020
Merged

Finishes Detr #21

merged 5 commits into from
Nov 11, 2020

Conversation

oke-aditya
Copy link
Owner

@oke-aditya oke-aditya commented Nov 11, 2020

Finishing the fit() and the tests etc,

I will leave the sanity API to @ramaneswaran .

@oke-aditya oke-aditya added the Model to Implement This model should be implmented label Nov 11, 2020
@oke-aditya oke-aditya self-assigned this Nov 11, 2020
@oke-aditya oke-aditya linked an issue Nov 11, 2020 that may be closed by this pull request
5 tasks
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #21 (5d89dad) into master (4da677f) will increase coverage by 0.91%.
The diff coverage is 79.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   73.62%   74.54%   +0.91%     
==========================================
  Files          27       27              
  Lines        1054     1092      +38     
==========================================
+ Hits          776      814      +38     
  Misses        278      278              
Flag Coverage Δ
unittests 74.54% <79.16%> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vision/models/detection/detr/engine.py 81.75% <72.22%> (-2.94%) ⬇️
vision/models/detection/detr/__init__.py 100.00% <100.00%> (ø)
vision/models/detection/detr/lightning_trainer.py 100.00% <100.00%> (ø)
vision/models/detection/detr/utils.py 42.10% <0.00%> (+42.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da677f...5d89dad. Read the comment docs.

@oke-aditya oke-aditya removed a link to an issue Nov 11, 2020
5 tasks
@oke-aditya
Copy link
Owner Author

Model Done !! 🥳 🎈

@oke-aditya oke-aditya merged commit 39e8395 into master Nov 11, 2020
@oke-aditya oke-aditya deleted the finish_detr branch November 11, 2020 19:24
@oke-aditya oke-aditya mentioned this pull request Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Model to Implement This model should be implmented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant