Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds type annotations #50

Merged
merged 1 commit into from
Nov 22, 2020
Merged

Adds type annotations #50

merged 1 commit into from
Nov 22, 2020

Conversation

oke-aditya
Copy link
Owner

Starts adding Type Annotations.

@oke-aditya oke-aditya added the enhancement New feature or request label Nov 20, 2020
@oke-aditya oke-aditya self-assigned this Nov 20, 2020
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #50 (7d3ab3b) into master (9f7239b) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   78.68%   78.74%   +0.06%     
==========================================
  Files          41       41              
  Lines        1370     1374       +4     
==========================================
+ Hits         1078     1082       +4     
  Misses        292      292              
Flag Coverage Δ
unittests 78.74% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
quickvision/models/classification/cnn/engine.py 78.16% <100.00%> (+0.09%) ⬆️
...kvision/models/components/torchvision_backbones.py 94.31% <100.00%> (ø)
quickvision/models/detection/detr/engine.py 82.26% <100.00%> (+0.12%) ⬆️
quickvision/models/detection/detr/model_factory.py 100.00% <100.00%> (ø)
quickvision/models/detection/faster_rcnn/engine.py 80.45% <100.00%> (+0.14%) ⬆️
quickvision/models/detection/retinanet/engine.py 82.40% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f7239b...7d3ab3b. Read the comment docs.

@oke-aditya oke-aditya merged commit 75080a7 into oke-aditya:master Nov 22, 2020
@oke-aditya oke-aditya deleted the add_annot branch November 22, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant