Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drops timm, fixes docs #63

Merged
merged 7 commits into from
Dec 2, 2020
Merged

Drops timm, fixes docs #63

merged 7 commits into from
Dec 2, 2020

Conversation

oke-aditya
Copy link
Owner

@oke-aditya oke-aditya commented Dec 2, 2020

Dropping create_timm_cnn as it is inconsistent with API and does not probably make any sense.

timm allows to create models using timm.create_model"") so we shouldn't be redoing it.

Might help #54

@oke-aditya oke-aditya added the bug Something isn't working label Dec 2, 2020
@oke-aditya oke-aditya self-assigned this Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #63 (7fe5338) into master (11f5c83) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   78.84%   78.78%   -0.06%     
==========================================
  Files          41       41              
  Lines        1541     1537       -4     
==========================================
- Hits         1215     1211       -4     
  Misses        326      326              
Flag Coverage Δ
unittests 78.78% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
quickvision/models/classification/cnn/__init__.py 100.00% <ø> (ø)
...kvision/models/classification/cnn/model_factory.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f5c83...3272850. Read the comment docs.

@oke-aditya
Copy link
Owner Author

Docs aren't fixed yet, but we are getting closer.

@oke-aditya oke-aditya merged commit e7b075e into oke-aditya:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant