Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up code like bolts #65

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Cleans up code like bolts #65

merged 4 commits into from
Dec 2, 2020

Conversation

oke-aditya
Copy link
Owner

Following PR in bolts.
It was a nice refactor to clean code. I moved the torchvision files to _model_zoo.py !
Now we can easily create a model zoo.

Thanks to @Borda and @akihironitta !!

@oke-aditya oke-aditya added the Medium Priority Should be addressed in few days label Dec 2, 2020
@oke-aditya oke-aditya self-assigned this Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #65 (66d7cf3) into master (e7b075e) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   78.78%   78.66%   -0.13%     
==========================================
  Files          41       42       +1     
  Lines        1537     1514      -23     
==========================================
- Hits         1211     1191      -20     
+ Misses        326      323       -3     
Flag Coverage Δ
unittests 78.66% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kvision/models/components/torchvision_backbones.py 96.82% <100.00%> (+2.50%) ⬆️
quickvision/pretrained/_model_zoo.py 100.00% <100.00%> (ø)
quickvision/pretrained/_pretrained_cnns.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b075e...66d7cf3. Read the comment docs.

@oke-aditya oke-aditya merged commit 2db89af into oke-aditya:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium Priority Should be addressed in few days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant