Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DETR COCO example #74

Merged
merged 4 commits into from
Dec 10, 2020
Merged

DETR COCO example #74

merged 4 commits into from
Dec 10, 2020

Conversation

zlapp
Copy link
Contributor

@zlapp zlapp commented Dec 7, 2020

Training DETR on coco using quickvision.

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #74 (bae2cdc) into master (b2b8a83) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   78.50%   78.39%   -0.12%     
==========================================
  Files          44       44              
  Lines        1540     1532       -8     
==========================================
- Hits         1209     1201       -8     
  Misses        331      331              
Flag Coverage Δ
unittests 78.39% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kvision/models/components/torchvision_backbones.py 96.82% <0.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b8a83...cbf8775. Read the comment docs.

examples/detection/detr_coco/train.py Outdated Show resolved Hide resolved
Copy link
Owner

@oke-aditya oke-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @zlapp. Just a few small changes are needed. Let me know if you can, or I will complete it.

examples/detection/detr_coco/box_ops.py Outdated Show resolved Hide resolved
examples/detection/detr_coco/box_ops.py Outdated Show resolved Hide resolved
examples/detection/detr_coco/box_ops.py Outdated Show resolved Hide resolved
examples/detection/detr_coco/box_ops.py Outdated Show resolved Hide resolved
examples/detection/detr_coco/train.py Outdated Show resolved Hide resolved
examples/detection/detr_coco/misc.py Outdated Show resolved Hide resolved
examples/detection/detr_coco/misc.py Outdated Show resolved Hide resolved
examples/detection/detr_coco/transforms.py Outdated Show resolved Hide resolved
examples/detection/detr_coco/misc.py Outdated Show resolved Hide resolved
examples/detection/detr_coco/transforms.py Outdated Show resolved Hide resolved
@oke-aditya
Copy link
Owner

oke-aditya commented Dec 7, 2020

@zlapp I have made all the changes but somehow I cannot push from your branch.
fatal: Authentication failed for 'https://github.com/zlapp/quickvision/

@oke-aditya oke-aditya added the documentation Improvements or additions to documentation label Dec 7, 2020
@hassiahk
Copy link
Contributor

hassiahk commented Dec 8, 2020

He needs to check the option Allow maintainers to edit when requesting a PR.

@oke-aditya
Copy link
Owner

Lint
./examples/detection/detr_coco/train.py:58: [W391] blank line at end of file

Copy link
Owner

@oke-aditya oke-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep ! LGTM. This example we show how customizable but powerful it is.

@oke-aditya oke-aditya merged commit c574986 into oke-aditya:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants