adding Instagram account to social media profile #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue raised by codeclimate wont be fixed as the extra code is needed. |
cuducos
requested changes
Jul 17, 2019
There was a problem hiding this comment.
Hi @sergiorgiraldo, thanks for the PR. I would like to raise two questions:
- Regarding your comment on Code Climate report (wont be fixed as the extra code is needed), have you considered refactoring the module (not the file)? I do think avoiding too long files is a good strategy in terms of maintenance and I would not dissmis the refactor suggestion just because extra code is needed. In this case, the
jarbas/dashboard/admin/__init__.pyhave two long described models (ReimbursementModelAdminandReimbursementSummaryModelAdmin) that could live in different files for a better organization, for example. Maybe 1dcfdb7 could inspire some changes. - Regarding the TODO to prepare a bulk insert with Instagram accounts, do you know any source for this information?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this Pull Request?
It allows instagram accounts to be stored and presented for each congressman. That's another layer for checking expenses, tracking if there are photos to support or debunk them.
What was done to achieve this purpose?
pretty straightforward, added a column in the database and renders this info in the grid.
How to test if it really works?
add an instagram account for a congressman who has expenses to be reviewed. The link for the account must be presented in jarbas under the social column.
Who can help reviewing it?
TODO
Prepare a bulk insert with instagram accounts.