Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: datasets, source files, clean up & mention to Jarbas #54

Merged
merged 7 commits into from
Sep 12, 2016

Conversation

cuducos
Copy link
Collaborator

@cuducos cuducos commented Sep 11, 2016

Fix #51

3. Commit your changes: `$ git commit -am 'Add some feature'`
4. Push to the branch to your fork: `$ git push origin my-new-feature`
5. Create a new _Pull Request_
2. Create your branch: `$ git checkout -b xx-new-stuff` where `xx` are your initials (e.g `jd` for John Doe)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When forking, the branch turns unnecessary since it's already owned by the contributor and no other user.

@cuducos
Copy link
Collaborator Author

cuducos commented Sep 11, 2016

Thanks for the review & feedback, @Irio. I think I fixed every point you raised ; )

@Irio Irio merged commit 0c0bb1e into master Sep 12, 2016
@Irio Irio deleted the ec-datasets-docs branch September 12, 2016 15:59
Irio pushed a commit that referenced this pull request Feb 27, 2018
cuducos pushed a commit that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants