Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean obsolete templates #1032

Merged
merged 11 commits into from
Dec 5, 2023
Merged

Clean obsolete templates #1032

merged 11 commits into from
Dec 5, 2023

Conversation

pdelboca
Copy link
Member

@pdelboca pdelboca commented Dec 5, 2023

This is part of #883 .

Notes:

  • The old aldryn template is no longer required. We have our own quote plugin now.
  • cms_homepage.html was cleaned in a previous PR. We are cleaninng all its snippets now (25ccf83)
  • We are no using breadcrumb so there is no need for the template
  • cms_article.html, cms_twocolumns.html and cms_childlist.html are no longer used.
  • newsletter.html and cms_apphooks.html are gonna be cleaned after migrating our members pages to CMS content. I added a note in the template for future reference.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8edbb6) 88.61% compared to head (8729851) 88.61%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1032   +/-   ##
========================================
  Coverage    88.61%   88.61%           
========================================
  Files           97       97           
  Lines         1203     1203           
  Branches        49       49           
========================================
  Hits          1066     1066           
  Misses         135      135           
  Partials         2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdelboca pdelboca requested a review from avdata99 December 5, 2023 09:28
@pdelboca pdelboca merged commit a922428 into develop Dec 5, 2023
2 checks passed
@pdelboca pdelboca deleted the clean-obsolete-templates branch December 5, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants