-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply style to social media links #980
Conversation
shashigharti
commented
Sep 1, 2023
- Fixes Add hover/click states for social links on the People cards #903
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #980 +/- ##
========================================
Coverage 88.35% 88.35%
========================================
Files 94 94
Lines 1176 1176
Branches 48 48
========================================
Hits 1039 1039
Misses 135 135
Partials 2 2 ☔ View full report in Codecov by Sentry. |
@lucpretti this PR changes the style of the links to look like these: Is this the desired outcome? |
Thank you @pdelboca. Please add the |
@lucpretti there is a discrepancy on how X data is handled. Some X accounts are My opinion is that in our database we should store |
Agree to normalise our database to |
Okay! I'll update to handle it in the frontend. Yeah, but it would be more costly than actually doing it by hand. We need to edit just a few of them. 😄 |
No problem! I'll do it by hand then! |