Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply style to social media links #980

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

shashigharti
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee7986e) 88.35% compared to head (9152776) 88.35%.
Report is 7 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #980   +/-   ##
========================================
  Coverage    88.35%   88.35%           
========================================
  Files           94       94           
  Lines         1176     1176           
  Branches        48       48           
========================================
  Hits          1039     1039           
  Misses         135      135           
  Partials         2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdelboca
Copy link
Member

pdelboca commented Nov 6, 2023

@lucpretti this PR changes the style of the links to look like these:

image

Is this the desired outcome?

@lucpretti
Copy link
Contributor

Thank you @pdelboca.

Please add the @ before the Twitter handle. Then we're good to merge.

@pdelboca
Copy link
Member

pdelboca commented Nov 6, 2023

@lucpretti there is a discrepancy on how X data is handled.

Some X accounts are @username and others are username. We should uniform this.

My opinion is that in our database we should store username and then manage the @ in the frontend since the X URL is not x.com/@username but rather x.com/username (x.com/@username will not raise an error, but it will redirect to x.com/username)

@lucpretti
Copy link
Contributor

Agree to normalise our database to username and manage the @ in the frontend. Is there a way to do it in a batch?

@pdelboca
Copy link
Member

pdelboca commented Nov 6, 2023

Okay! I'll update to handle it in the frontend.

Yeah, but it would be more costly than actually doing it by hand. We need to edit just a few of them. 😄

@lucpretti
Copy link
Contributor

No problem! I'll do it by hand then!

@pdelboca pdelboca merged commit 2098ff7 into develop Nov 8, 2023
2 checks passed
@pdelboca pdelboca deleted the 903/apply-styles-for-socialmedia-links branch November 8, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hover/click states for social links on the People cards
4 participants