Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new global variable hide #817

Merged
merged 5 commits into from
Aug 7, 2020

Conversation

mpourismaiel
Copy link
Member

What this PR does / why we need it:
Add new global variable hide and tests in the fragment fallthrough dev page for it

Which issue this PR fixes:
fixes #731

Release note:

- added new global variable `hide` in order to bypass global fragments

@mpourismaiel mpourismaiel added this to the v0.18.0 milestone Aug 4, 2020
@mpourismaiel mpourismaiel requested a review from stp-ip August 4, 2020 01:43
@mpourismaiel mpourismaiel self-assigned this Aug 4, 2020
stp-ip
stp-ip previously approved these changes Aug 7, 2020
Copy link
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for you to merge after the tiny suggestion.

exampleSite/content/docs/fragments/content.md Outdated Show resolved Hide resolved
Co-authored-by: Michael Grosser <development@stp-ip.net>
@mpourismaiel
Copy link
Member Author

We need an approving review in order to merge. Committed the suggestion.

Copy link
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve got removed with the new commit. Should have known ;)

@stp-ip stp-ip merged commit 6fa02c9 into okkur:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

how to bypass _global ?
2 participants