Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve-users-coverage #1549

Merged
merged 16 commits into from
Dec 27, 2024
Prev Previous commit
Next Next commit
Revert fix
okorach committed Dec 26, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 40f714838ec8041f53b438455746004007aaac68
2 changes: 1 addition & 1 deletion sonar/sqobject.py
Original file line number Diff line number Diff line change
@@ -152,7 +152,7 @@ def delete(self) -> bool:
ok = self.post(api=self.__class__.API[c.DELETE], params=self.api_params(c.DELETE)).ok
if ok:
log.info("Removing from %s cache", str(self.__class__.__name__))
self.__class__.CACHE.pop(self, None)
self.__class__.CACHE.pop(self)
except (ConnectionError, RequestException) as e:
utilities.handle_error(e, f"deleting {str(self)}", catch_http_errors=(HTTPStatus.NOT_FOUND,))
raise exceptions.ObjectNotFound(self.key, f"{str(self)} not found")