Fix missing callback dependencies #2188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryancunningham-okta
approved these changes
Mar 20, 2024
| @@ -478,15 +478,15 @@ const DataTable = ({ | |||
|
|
|||
| const convertColumnToFilter = useCallback( | |||
| (column: DataTableColumn<DataTableRowData>) => | |||
| column.enableColumnFilter && column.accessorKey | |||
| column.enableColumnFilter !== false && column.accessorKey | |||
There was a problem hiding this comment.
Is enableColumnFilter a boolean? Not sure we'd need to be this specific here. Unless there is some context I am missing
There was a problem hiding this comment.
I think this is part of material-react-table (right?), or I'd make a comment about is or has prefixes.
I also agree with @bryancunningham-okta. Why not this instead?
Suggested change
| column.enableColumnFilter !== false && column.accessorKey | |
| !column.enableColumnFilter && column.accessorKey |
There was a problem hiding this comment.
This is coming from Material-React-Table. In a column definition, if you set enableColumnFilter to false, a filter won't display for that column.
There was a problem hiding this comment.
I guess what I'm getting at is, enableColumnFilter is either truthy or falsey right? Can just be this
column.enableColumnFilter && column.accessorKey
Comment on lines
+507
to
+523
| return accumulator.concat(filter); | ||
| } | ||
| } | ||
| } else if ("accessorKey" in item) { | ||
| // Checks if it's a column | ||
| const filter = convertColumnToFilter(item); | ||
| if (filter) { | ||
| accumulator.push(); | ||
| return accumulator.concat(filter); | ||
| } | ||
| } else if ("label" in item) { | ||
| // Checks if it's a DataFilter | ||
| accumulator.push(item); | ||
| return accumulator.concat(item); | ||
| } | ||
| // If none of the conditions match, item is ignored (not mapping to undefined) | ||
| return accumulator; | ||
| }, []); | ||
| }, [columns, filtersProp]); | ||
| }, [columns, filtersProp, convertColumnToFilter]); |
bryancunningham-okta
pushed a commit
that referenced
this pull request
Mar 25, 2024
* refactor: replace push with concat * refactor: fix missing dependencies * fix: fix broken filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few missing dependencies in
useCallbackanduseMemo, and replaces.push()with.concat()as per Kevin's suggestion.