Add status lamp [DES-5591] (pr2) #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGhadyani-Okta
approved these changes
Jun 5, 2024
bryancunningham-okta
pushed a commit
that referenced
this pull request
Jun 10, 2024
DES-5591 fix: add status lamp [DES-5591]
stephanieyoshimoto-okta
pushed a commit
that referenced
this pull request
Jul 15, 2024
DES-5591 fix: add status lamp [DES-5591]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This take 2 after messing up the history of my original PR fixing commit signing issues. Please refer to the original PR for comments
DES-5591
Summary
Adds the previously deprecated
Statuslampvariant. This was removed recently to simplify the style ofStatusbut we've since found use cases forlampand numerous existing uses that necessitate the style.Testing & Screenshots