Adds timezone support to DatePicker #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+82
to
+88
| export const useOdysseyDateFields = ({ | ||
| defaultValue, | ||
| isDateEnabled = () => true, | ||
| isMonthEnabled = () => true, | ||
| isYearEnabled = () => true, | ||
| minDate: minDateProp, | ||
| maxDate: maxDateProp, |
There was a problem hiding this comment.
I skimmed this file. I'm gonna assume it's good.
bryancunningham-okta
force-pushed
the
bc_OKTA-729288-datepicker-add-timezome
branch
from
e513073 to
56b2c3a
Compare
KevinGhadyani-Okta
previously approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Code is fine. We've reviewed it, and it's good!
I'm concerned about the 5-second time before the error displays. I'd like to only have it on Blur or talk to other design folks and see what they think. We don't have this anywhere else (displaying an error message ourselves), so I'd like to get confirmation.
We should also look at potentially adding more validation functionality to Odyssey if we want it to function a certain way.
| (validationError) => { | ||
| const timeoutId = setTimeout(() => { | ||
| setDisplayedErrorMessage(validationError); | ||
| }, 5000); |
There was a problem hiding this comment.
We should put this 5000 as a constant at the top of the file.
bryancunningham-okta
force-pushed
the
bc_OKTA-729288-datepicker-add-timezome
branch
from
05bb779 to
b03118b
Compare
KevinGhadyani-Okta
approved these changes
Jul 31, 2024
oktapp-aperture-okta
bot
deleted the
bc_OKTA-729288-datepicker-add-timezome
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-729288
Summary
Adds time zone support by
timeZone, timezoneOptions, timeZoneLabelprops.TimeZonePickeriftimezoneOptionsare provided.Testing & Screenshots