fix: remove invalid pseudo element from theme overrides #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGhadyani-Okta
approved these changes
Jul 30, 2024
bryancunningham-okta
force-pushed
the
mmo-OKTA-755668-remove-invalid-moz-pseudo-element
branch
from
233a924 to
97599c3
Compare
bryancunningham-okta
force-pushed
the
mmo-OKTA-755668-remove-invalid-moz-pseudo-element
branch
from
97599c3 to
e8a792b
Compare
oktapp-aperture-okta
bot
deleted the
mmo-OKTA-755668-remove-invalid-moz-pseudo-element
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-755668
Summary
-moz-search-cancel-buttonis not a valid pseudo-element, unlike -webkit-search-cancel-button, but they are both treated equal in the Odyssey theme overrides, which should be removed.Testing & Screenshots
Error example:
