Redo react 17 compatibility #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8a51b78.
… React 17 compatibility
bryancunningham-okta
approved these changes
Dec 3, 2024
bryancunningham-okta
pushed a commit
that referenced
this pull request
Dec 3, 2024
bryancunningham-okta
pushed a commit
that referenced
this pull request
Dec 3, 2024
bryancunningham-okta
deleted the
bs-OKTA-839342-redo-react-17-compatibility
branch
oktapp-aperture-okta bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
DES-6856 Redo react 17 compatibility (#2433) * Revert "React 17 compatibility (as patch to 1.28) (#2431)" This reverts commit 8a51b78. * fix: move UiShell, renderReactInWebComponent into separate export for React 17 compatibility * fix: related storybook updates build: bump versions for 1.28.2 docs: update CHANGELOG for 1.28.2 chore(odyssey-react-mui): leave main at 1.28.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic import approach did not work, as consumers using build tooling / bundlers will transform that dynamic import (and will have to resolve it in order to do so). Instead, revert those changes and put UiShell and renderReactInWebComponent into a separate export and appropriately refactor other related files that reference those.
OKTA-839342
Summary
Testing & Screenshots