-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Jest tests for e2e apps #114
Merged
eng-services-aperture-github-bot-okta
merged 12 commits into
master
from
od-jest-fix-OKTA-551971
Jan 24, 2023
Merged
Enable Jest tests for e2e apps #114
eng-services-aperture-github-bot-okta
merged 12 commits into
master
from
od-jest-fix-OKTA-551971
Jan 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4aba255
to
f0adb9b
Compare
scripts/setup-e2e.sh
Outdated
@@ -88,10 +88,15 @@ if ! yarn build; then | |||
exit ${FAILED_SETUP} | |||
fi | |||
|
|||
pushd ./dist | |||
npx yalc publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can these calls to npx yalc
be replaced with yarn
commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced with yarn test:apps:prepare
061534d
to
dabe69b
Compare
dabe69b
to
6a009a9
Compare
readme
jaredperreault-okta
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jest-preset-angular
.Adds
@okta/okta-angular
totransformIgnorePatterns
in jest configyarn test:unit
for test apps. Run it duringe2e
script in Bacon.Internal ref: OKTA-551971