Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle routes without path segments #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PatrickSchnoop
Copy link

Protect lazy loaded routes without path segments with canLoad-Guard.

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

If you want to protect a route without any path segments with a canLoad-Guard, an exception is thrown.

const routes = [{
 path: '',
 canLoad: [ OktaAuthGuard ],
 ...
}]

Issue Number: N/A

What is the new behavior?

Routes without path segments can be protected with a canLoad-Guard.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

Protect lazy loaded routes without path segments with canLoad-Guard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants