fix tests/lint for OV/step feature

okta · Jan 20, 2022 · f1b290b · f1b290b
1 parent dae18ca
commit f1b290b
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 12 deletions.
diff --git a/lib/idx/remediate.ts b/lib/idx/remediate.ts
@@ -48,7 +48,8 @@ export function getRemediator(
   let remediator;
   // remediation name specified by caller - fast-track remediator lookup 
   if (options.step) {
-    const remediation = idxRemediations.find(({ name }) => name === options.step);
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    const remediation = idxRemediations.find(({ name }) => name === options.step)!;
     const T = remediators[remediation.name];
     return new T(remediation, values);
   }

diff --git a/lib/idx/remediators/EnrollmentChannelData.ts b/lib/idx/remediators/EnrollmentChannelData.ts
@@ -23,7 +23,7 @@ export type EnrollmentChannelDataValues = RemediationValues & {
 export class EnrollmentChannelData extends Remediator {
   static remediationName = 'enrollment-channel-data';
 
-  values: EnrollmentChannelDataValues;
+  values!: EnrollmentChannelDataValues;
 
   map = {
     email: [],

diff --git a/lib/idx/remediators/RemediationDescriptor.ts b/lib/idx/remediators/RemediationDescriptor.ts
diff --git a/lib/idx/remediators/SelectEnrollmentChannel.ts b/lib/idx/remediators/SelectEnrollmentChannel.ts
@@ -24,7 +24,7 @@ export type SelectEnrollmentChannelValues = RemediationValues & {
 export class SelectEnrollmentChannel extends Remediator {
   static remediationName = 'select-enrollment-channel';
 
-  values: SelectEnrollmentChannelValues;
+  values!: SelectEnrollmentChannelValues;
 
   canRemediate() {
     return Boolean(this.values.channel);
@@ -41,14 +41,15 @@ export class SelectEnrollmentChannel extends Remediator {
     };
   }
 
-  private getChannels(): IdxOption[] {
+  private getChannels(): IdxOption[] | undefined {
     const authenticator: IdxRemediationValue = getAuthenticatorFromRemediation(this.remediation);
     const remediationValue = authenticator.value as IdxRemediationValueForm;
     return remediationValue.form.value.find(({ name }) => name === 'channel')?.options;
   }
 
   getData() {
-    const remediationValue = this.remediation.value[0].value as IdxRemediationValueForm;
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    const remediationValue = this.remediation!.value![0].value as IdxRemediationValueForm;
     return {
       authenticator: {
         id: remediationValue.form.value[0].value,

diff --git a/lib/idx/run.ts b/lib/idx/run.ts
@@ -107,7 +107,8 @@ export async function run(
       actions,
       withCredentials,
       exchangeCodeForTokens,
-      autoRemediate
+      autoRemediate,
+      step
     } = options;
 
     // Only one flow can be operating at a time
@@ -155,7 +156,7 @@ export async function run(
         terminal,
         canceled,
         messages: messagesFromResp,
-      } = await remediate(idxResponse, values, { remediators, actions, flow });
+      } = await remediate(idxResponse, values, { remediators, actions, flow, step });
       idxResponse = idxResponseFromResp || idxResponse;
 
       // Track fields from remediation response

diff --git a/test/spec/idx/register.ts b/test/spec/idx/register.ts
@@ -1912,12 +1912,14 @@ describe('idx/register', () => {
       const {
         authClient,
         selectAuthenticatorResponse,
+        successWithInteractionCodeResponse
       } = testContext;
 
       chainResponses([
         selectAuthenticatorResponse,
         enrollPollResponse,
         enrollmentChannelDataSmsResponse,
+        successWithInteractionCodeResponse
       ]);
 
       jest.spyOn(mocked.introspect, 'introspect')
@@ -1932,18 +1934,19 @@ describe('idx/register', () => {
       await register(authClient, {
         authenticator: AuthenticatorKey.OKTA_VERIFY
       });
-      const { nextStep: { options } } = await proceed(authClient, {
+      let res = await proceed(authClient, {
         step: 'select-enrollment-channel'
       });
-
+      const { options } = res.nextStep!;
       expect(options).toContainEqual({
         label: 'SMS',
         value: 'sms'
       });
 
-      const { nextStep: { inputs } } = await proceed(authClient, {
+      res = await proceed(authClient, {
         channel: 'phoneNumber'
       });
+      const { inputs } = res.nextStep!;
 
       expect(enrollPollResponse.proceed).toHaveBeenCalledWith(
         'select-enrollment-channel',
@@ -1968,12 +1971,14 @@ describe('idx/register', () => {
       const {
         authClient,
         selectAuthenticatorResponse,
+        successWithInteractionCodeResponse
       } = testContext;
 
       chainResponses([
         selectAuthenticatorResponse,
         enrollPollResponse,
         enrollmentChannelDataEmailResponse,
+        successWithInteractionCodeResponse
       ]);
 
       jest.spyOn(mocked.introspect, 'introspect')
@@ -1988,18 +1993,20 @@ describe('idx/register', () => {
       await register(authClient, {
         authenticator: AuthenticatorKey.OKTA_VERIFY
       });
-      const { nextStep: { options } } = await proceed(authClient, {
+      let res = await proceed(authClient, {
         step: 'select-enrollment-channel'
       });
+      const { options } = res.nextStep!;
 
       expect(options).toContainEqual({
         label: 'EMAIL',
         value: 'email'
       });
 
-      const { nextStep: { inputs } } = await proceed(authClient, {
+      res = await proceed(authClient, {
         channel: 'email'
       });
+      const { inputs }  = res.nextStep!;
 
       expect(enrollPollResponse.proceed).toHaveBeenCalledWith(
         'select-enrollment-channel',