fix: post set_storage event when storage is cleared on logout

.
okta · May 5, 2022 · fa79c0b · fa79c0b
1 parent 569994a
commit fa79c0b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/lib/TokenManager.ts b/lib/TokenManager.ts
@@ -278,8 +278,8 @@ export class TokenManager implements TokenManagerInterface {
   }
 
   // for synchronization of LocalStorage cross tabs for IE11
-  private emitSetStorageEvent() {
-    if (isIE11OrLess()) {
+  private emitSetStorageEvent(force = false) {
+    if (isIE11OrLess() || force) {
       const storage = this.storage.getStorage();
       this.emitter.emit(EVENT_SET_STORAGE, storage);
     }
@@ -434,6 +434,7 @@ export class TokenManager implements TokenManagerInterface {
   clear() {
     this.clearExpireEventTimeoutAll();
     this.storage.clearStorage();
+    this.emitSetStorageEvent(true);
   }
 
   clearPendingRemoveTokens() {

diff --git a/test/spec/services/SyncStorageService.ts b/test/spec/services/SyncStorageService.ts
@@ -40,7 +40,10 @@ describe('SyncStorageService', () => {
       getStorage: jest.fn().mockImplementation(() => storage),
       setStorage: jest.fn().mockImplementation((newStorage) => {
         storage = newStorage;
-      })
+      }),
+      clearStorage: jest.fn().mockImplementation(() => {
+        storage = {};
+      }),
     };
     sdkMock = {
       options: {},
@@ -210,6 +213,18 @@ describe('SyncStorageService', () => {
       tokenManager.add('idToken', tokens.standardIdTokenParsed);
       expect(serviceChannel.postMessage).toHaveBeenCalledTimes(1); // only "added"
     });
+
+    it('should post "set_storage" event when token storage is cleared', () => {
+      createInstance();
+      const serviceChannel = (service as any).channel;
+      jest.spyOn(serviceChannel, 'postMessage');
+      tokenManager.clear();
+      expect(serviceChannel.postMessage).toHaveBeenCalledTimes(1);
+      expect(serviceChannel.postMessage).toHaveBeenNthCalledWith(1, {
+        type: 'set_storage',
+        storage: {},
+      });
+    });
   });
 
   describe('IE11', () => {