fix: omit cookies by default (#354)

okta · Mar 27, 2020 · ff995e5 · ff995e5
1 parent c08bb3a
commit ff995e5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/okta-auth-js/lib/fetch/fetchRequest.js b/packages/okta-auth-js/lib/fetch/fetchRequest.js
@@ -57,7 +57,7 @@ function fetchRequest(method, url, args) {
     method: method,
     headers: args.headers,
     body: body,
-    credentials: args.withCredentials === false ? 'omit' : 'include'
+    credentials: args.withCredentials ? 'include' : 'omit'
   })
   .then(function(response) {
     var error = !response.ok;

diff --git a/packages/okta-auth-js/test/spec/fetch-request.js b/packages/okta-auth-js/test/spec/fetch-request.js
@@ -60,7 +60,7 @@ describe('fetchRequest', function () {
           method: requestMethod,
           headers: requestHeaders,
           body: JSON.stringify(requestJSON),
-          credentials: 'include'
+          credentials: 'omit'
         });
       });
     });
@@ -80,20 +80,20 @@ describe('fetchRequest', function () {
           method: requestMethod,
           headers: requestHeaders,
           body: requestText,
-          credentials: 'include'
+          credentials: 'omit'
         });
       });
     });
 
 
-    it('Can omit credentials', function() {
+    it('Can include credentials', function() {
       return fetchRequest(requestMethod, requestUrl, {
-        withCredentials: false
+        withCredentials: true
       })
       .then(() => {
         expect(fetchSpy).toHaveBeenCalledWith(requestUrl, {
           method: requestMethod,
-          credentials: 'omit'
+          credentials: 'include'
         });
       });
     });